Messages in this thread | | | From | Gwendal Grignou <> | Date | Sat, 17 Mar 2018 05:31:01 +0000 | Subject | Re: [PATCH v2 6/6] platform/chrome: mfd/cros_ec_dev: Add sysfs entry to set keyboard wake lid angle |
| |
On Wed, Mar 7, 2018 at 8:28 AM Lee Jones <lee.jones@linaro.org> wrote:
> On Wed, 21 Feb 2018, Enric Balletbo i Serra wrote:
> > From: Gwendal Grignou <gwendal@chromium.org> > > > > This adds a sysfs attribute (/sys/class/chromeos/cros_ec/kb_wake_angle) > > used to set and get the keyboard wake lid angle. This attribute is > > present only if 2 accelerometers are controlled by the EC. > > > > This patch also moves the cros_ec features check before the device is > > added so the features map obtained from the EC is ready on time.
Enric,
I found an error in the patch. During the merge, the code that set has_kb_wake_angle in cros_ec_sensors_register() has been lost. I uploaded a change (that also remove call for a non-existent cros-ec-angle platform driver) at https://chromium-review.googlesource.com/#/c/866106.
Gwendal. > > > > Signed-off-by: Gwendal Grignou <gwendal@chromium.org> > > Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com> > > --- > > Changes since v1: > > - Suggested by Andy Shevchenko: > > - Use the previous defined to_cros_ec_dev > > - Use one line when fits in 80 characters. > > - Use DEVICE_ATTR_RW variant. > > > > drivers/platform/chrome/cros_ec_sysfs.c | 81 +++++++++++++++++++++++++++++++++
> > drivers/mfd/cros_ec_dev.c | 19 ++++---- > > include/linux/mfd/cros_ec.h | 1 +
> Please send me a PR with this patch contained.
> Acked-by: Lee Jones <lee.jones@linaro.org>
> -- > Lee Jones > Linaro Services Technical Lead > Linaro.org │ Open source software for ARM SoCs > Follow Linaro: Facebook | Twitter | Blog
| |