Messages in this thread | | | Date | Fri, 16 Mar 2018 15:55:38 +0000 | From | Al Viro <> | Subject | Re: [PATCH] dcache: remove trailing whitespace |
| |
On Fri, Mar 16, 2018 at 03:34:00PM +0100, Niklas Cassel wrote: > Remove trailing whitespace. > Remove empty line and trailing whitespace after function comments. > Remove an extra space in one of the comments. > Fix a typo in of the comments. > > Signed-off-by: Niklas Cassel <niklas.cassel@axis.com> > --- > I know that these type of patches are not really appreciated, > however, there is enough trailing whitespace in this file to > distract me from reading the real code.
No, they are not, and here's why:
Applying: dcache: remove trailing whitespace error: patch failed: fs/dcache.c:254 error: fs/dcache.c: patch does not apply Patch failed at 0001 dcache: remove trailing whitespace
... which, BTW, happens in *all* branches. If you do that kind of stuff, at least do it against something in the public trees and _tell_ _what_ _it_ _is_ _against_.
Or send a sed script for doing that[1] - even Linus takes those for search-and-replace stuff.
[1] sed -i -e 's/[[:space:]]*$//' fs/dcache.c or, if you are not sending to Linus, ed fs/dcache.c <<'EOF' %s/[[:space:]]*$// wq EOF
Not applied. Please, do it sanely. BTW, which editor is _that_ annoying? Anything that shoves trailing whitespace in my face would've been either configured (with considerable cursing at the people who'd set such defaults) or, should that prove impossible, given a boot...
| |