Messages in this thread Patch in this message | | | Date | Fri, 16 Mar 2018 09:49:28 -0400 (EDT) | Subject | Re: [PATCH] rxrpc: remove redundant initialization of variable 'len' | From | David Miller <> |
| |
From: Colin King <colin.king@canonical.com> Date: Mon, 12 Mar 2018 17:25:38 +0000
> From: Colin Ian King <colin.king@canonical.com> > > The variable 'len' is being initialized with a value that is never > read and it is re-assigned later, hence the initialization is redundant > and can be removed. > > Cleans up clang warning: > net/rxrpc/recvmsg.c:275:15: warning: Value stored to 'len' during its > initialization is never read > > Signed-off-by: Colin Ian King <colin.king@canonical.com>
Hehe, if the diff provided just 2 more lines of context at the bottom we'd be able to see the overriding assignment :-)
> @@ -272,7 +272,7 @@ static int rxrpc_locate_data(struct rxrpc_call *call, struct sk_buff *skb, > unsigned int *_offset, unsigned int *_len) > { > unsigned int offset = sizeof(struct rxrpc_wire_header); > - unsigned int len = *_len; > + unsigned int len; > int ret; > u8 annotation = *_annotation; > > -- > 2.15.1 >
Applied, thanks Colin.
| |