Messages in this thread | | | From | Kalle Valo <> | Subject | Re: [PATCH] [v2] Bluetooth: btrsi: rework dependencies | Date | Fri, 16 Mar 2018 06:54:19 +0200 |
| |
Arnd Bergmann <arnd@arndb.de> writes:
> On Thu, Mar 15, 2018 at 7:30 PM, Marcel Holtmann <marcel@holtmann.org> wrote: >> Hi Arnd, >> >>> The linkage between the bluetooth driver and the wireless >>> driver is not defined properly, leading to build problems >>> such as: >>> >>> warning: (BT_HCIRSI) selects RSI_COEX which has unmet direct >>> dependencies (NETDEVICES && WLAN && WLAN_VENDOR_RSI && BT_HCIRSI && >>> RSI_91X) >>> drivers/net/wireless/rsi/rsi_91x_main.o: In function `rsi_read_pkt': >>> (.text+0x205): undefined reference to `rsi_bt_ops' >>> >>> As the dependency is actually the reverse (RSI_91X uses >>> the BT_RSI driver, not the other way round), this changes >>> the dependency to match, and enables the bluetooth driver >>> from the RSI_COEX symbol. >>> >>> Fixes: 38aa4da50483 ("Bluetooth: btrsi: add new rsi bluetooth driver") >>> Signed-off-by: Arnd Bergmann <arnd@arndb.de> >>> --- >>> v2: Pick a different from v1 >>> --- >>> drivers/bluetooth/Kconfig | 4 +--- >>> drivers/net/wireless/rsi/Kconfig | 4 +++- >>> 2 files changed, 4 insertions(+), 4 deletions(-) >> >> Acked-by: Marcel Holtmann <marcel@holtmann.org> >> >> Since I think Kalle still has to take it through his tree until the >> btrsi driver makes it into net-next.
Yes, I have to take this as I haven't sent the original patch to Dave yet.
> Kalle, please wait for v3 though, I just ran into another build > failure caused by a typo in v2.
Ok, I saw it.
-- Kalle Valo
| |