Messages in this thread | | | Subject | Re: [PATCH 5/8] trace_uprobe: Support SDT markers having reference count (semaphore) | From | Ravi Bangoria <> | Date | Fri, 16 Mar 2018 14:31:34 +0530 |
| |
On 03/15/2018 10:18 PM, Steven Rostedt wrote: > On Tue, 13 Mar 2018 18:26:00 +0530 > Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com> wrote: > >> +static void sdt_increment_ref_ctr(struct trace_uprobe *tu) >> +{ >> + struct uprobe_map_info *info; >> + struct vm_area_struct *vma; >> + unsigned long vaddr; >> + >> + uprobe_start_dup_mmap(); > Please add a comment here that this function ups the mm ref count for > each info returned. Otherwise it's hard to know what that mmput() below > matches.
Sure. Will add it.
Thanks for the review, Ravi
| |