Messages in this thread | | | Subject | Re: [PATCH 0/2] net: phy: relax error checking when creating sysfs link netdev->phydev | From | Grygorii Strashko <> | Date | Fri, 16 Mar 2018 15:13:09 -0500 |
| |
On 03/16/2018 02:54 PM, Andrew Lunn wrote: >> The phydrv->mdiodrv.flags can be accessible only after call to of_phy_connect()/phy_connect(), > > You need to use a function like of_phy_find_device() to get the > phydev, set the flag, and then call phy_connect_direct().
So, do you propose me to replace direct calls of of_phy_connect()/phy_connect() in CPSW driver with buddies of the same functions? Right?
cpsw_slave_open() { .... if (slave->data->phy_node) { phy = of_phy_connect(priv->ndev, slave->data->phy_node, &cpsw_adjust_link, 0, slave->data->phy_if); ----- replace ^^^^ with below { struct phy_device *phy = of_phy_find_device(phy_np); int ret;
if (!phy) return NULL;
phy->dev_flags = flags;
----- [set flag in phydrv->mdiodrv.flags]
ret = phy_connect_direct(dev, phy, hndlr, iface);
/* refcount is held by phy_connect_direct() on success */ put_device(&phy->mdio.dev);
return ret ? NULL : phy; } ----- if (!phy) { dev_err(priv->dev, "phy \"%pOF\" not found on slave %d\n", slave->data->phy_node, slave->slave_num); return; } } else { phy = phy_connect(priv->ndev, slave->data->phy_id, &cpsw_adjust_link, slave->data->phy_if); ----- replace ^^^^ with below { struct phy_device *phydev; struct device *d; int rc;
/* Search the list of PHY devices on the mdio bus for the * PHY with the requested name */ d = bus_find_device_by_name(&mdio_bus_type, NULL, bus_id); if (!d) { pr_err("PHY %s not found\n", bus_id); return ERR_PTR(-ENODEV); } phydev = to_phy_device(d);
----- [set flag in phydrv->mdiodrv.flags]
rc = phy_connect_direct(dev, phydev, handler, interface); put_device(d); if (rc) return ERR_PTR(rc);
return phydev; } ----- if (IS_ERR(phy)) { dev_err(priv->dev, "phy \"%s\" not found on slave %d, err %ld\n", slave->data->phy_id, slave->slave_num, PTR_ERR(phy)); return; } } }
and all above just to set a flag which will be used by just one driver as of now.
Hm. Is this some sort of punishment ;) Sry. I'll probably will take a pause.
-- regards, -grygorii
| |