Messages in this thread Patch in this message | | | From | Masahiro Yamada <> | Subject | [PATCH v4 2/7] kbuild: remove wrong 'touch' in adjust_autoksyms.sh | Date | Fri, 16 Mar 2018 16:37:10 +0900 |
| |
The comment mentions it creates autoksyms.h in case it is missing, but the actual code touches it when it does exists.
The build system creates it anyway because <linux/export.h> and <asm-generic/export.h> need it.
The code would not have worked as intended, and people have not noticed it. This is a proof that we can simply remove it.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> Acked-by: Nicolas Pitre <nico@linaro.org> ---
Changes in v4: None Changes in v3: None Changes in v2: - Remove the code instead of fixing it
scripts/adjust_autoksyms.sh | 3 --- 1 file changed, 3 deletions(-)
diff --git a/scripts/adjust_autoksyms.sh b/scripts/adjust_autoksyms.sh index a162258..e0dd0d5 100755 --- a/scripts/adjust_autoksyms.sh +++ b/scripts/adjust_autoksyms.sh @@ -48,9 +48,6 @@ case "${KCONFIG_CONFIG}" in . "./${KCONFIG_CONFIG}" esac -# In case it doesn't exist yet... -if [ -e "$cur_ksyms_file" ]; then touch "$cur_ksyms_file"; fi - # Generate a new ksym list file with symbols needed by the current # set of modules. cat > "$new_ksyms_file" << EOT -- 2.7.4
| |