lkml.org 
[lkml]   [2018]   [Mar]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH v3] vsprintf: Prevent crash when dereferencing invalid pointers
    From
    Date
    On Thu, 2018-03-15 at 16:26 +0100, Petr Mladek wrote:
    > On Thu 2018-03-15 15:09:03, Andy Shevchenko wrote:
    > > On Wed, 2018-03-14 at 15:09 +0100, Petr Mladek wrote:
    > > > We already prevent crash when dereferencing some obviously broken
    > > > pointers. But the handling is not consistent. Sometimes we print
    > > > "(null)"
    > > > only for pure NULL pointer, sometimes for pointers in the first
    > > > page and
    > >
    > >
    > > > sometimes also for pointers in the last page (error codes).
    > >
    > > I still think that printing a hex value of the error code is much
    > > better
    > > than some odd "(efault)".
    >
    > Do you mean (err:0e)? Google gives rather confusing answers for this.

    More like "(0xHHHH)" (we have already more than 512 error code numbers.


    > I am not super excited about (efault). But it seems to be less
    > cryptic and the style is more similar to (null).
    >
    > Best Regards,
    > Petr

    --
    Andy Shevchenko <andriy.shevchenko@linux.intel.com>
    Intel Finland Oy

    \
     
     \ /
      Last update: 2018-03-16 19:20    [W:6.127 / U:0.112 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site