lkml.org 
[lkml]   [2018]   [Mar]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] PCI/DPC: Fix PCI legacy interrupt acknowledgement
On 2018-03-15 02:22, Keith Busch wrote:
> On Wed, Mar 14, 2018 at 09:20:48PM +0530, Oza Pawandeep wrote:
>> Current DPC driver acknowledges the interrupt in deferred work, which
>> works
>> since MSI are edge triggered.
>>
>> But when MSI is disabled (e.g. pci=nomsi boot option) port service
>> driver falls back to PCI legacy INT interrupt.
>>
>> With current code we do not acknowledge the interrupt back in
>> dpc_irq()
>> and we get dpc interrupt storm.
>>
>> This patch acknowledges the interrupt in interrupt handler.
>>
>> Signed-off-by: Oza Pawandeep <poza@codeaurora.org>
>
> Thanks, this looks good to me.
>
> Reviewed-by: Keith Busch <keith


checkpatch script shows
WARNING: 'acknowledgement' may be misspelled - perhaps 'acknowledgment'?

but dictionaries shows acknowledgement.

Regards,
Oza.

\
 
 \ /
  Last update: 2018-03-15 08:54    [W:0.108 / U:1.168 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site