lkml.org 
[lkml]   [2018]   [Mar]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 4/8] Uprobe: Export uprobe_map_info along with uprobe_{build/free}_map_info()
    On Tue, 13 Mar 2018 18:25:59 +0530
    Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com> wrote:

    > These exported data structure and functions will be used by other
    > files in later patches.

    I'm reluctantly OK with the above.

    >
    > No functionality changes.

    Please remove this line. There are functionality changes. Turning a
    static inline into an exported function *is* a functionality change.

    -- Steve

    >
    > Signed-off-by: Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com>
    > ---
    > include/linux/uprobes.h | 9 +++++++++
    > kernel/events/uprobes.c | 14 +++-----------
    > 2 files changed, 12 insertions(+), 11 deletions(-)
    >
    > diff --git a/include/linux/uprobes.h b/include/linux/uprobes.h
    > index 0a294e9..7bd2760 100644
    > --- a/include/linux/uprobes.h
    > +++ b/include/linux/uprobes.h
    > @@ -109,12 +109,19 @@ enum rp_check {
    > RP_CHECK_RET,
    > };
    >
    > +struct address_space;
    > struct xol_area;
    >
    > struct uprobes_state {
    > struct xol_area *xol_area;
    > };
    >
    > +struct uprobe_map_info {
    > + struct uprobe_map_info *next;
    > + struct mm_struct *mm;
    > + unsigned long vaddr;
    > +};
    > +
    > extern int set_swbp(struct arch_uprobe *aup, struct mm_struct *mm, unsigned long vaddr);
    > extern int set_orig_insn(struct arch_uprobe *aup, struct mm_struct *mm, unsigned long vaddr);
    > extern bool is_swbp_insn(uprobe_opcode_t *insn);
    > @@ -149,6 +156,8 @@ struct uprobes_state {
    > extern bool arch_uprobe_ignore(struct arch_uprobe *aup, struct pt_regs *regs);
    > extern void arch_uprobe_copy_ixol(struct page *page, unsigned long vaddr,
    > void *src, unsigned long len);
    > +extern struct uprobe_map_info *uprobe_free_map_info(struct uprobe_map_info *info);
    > +extern struct uprobe_map_info *uprobe_build_map_info(struct address_space *mapping, loff_t offset, bool is_register);
    > #else /* !CONFIG_UPROBES */
    > struct uprobes_state {
    > };
    > diff --git a/kernel/events/uprobes.c b/kernel/events/uprobes.c
    > index 081b88c1..e7830b8 100644
    > --- a/kernel/events/uprobes.c
    > +++ b/kernel/events/uprobes.c
    > @@ -695,23 +695,15 @@ static void delete_uprobe(struct uprobe *uprobe)
    > put_uprobe(uprobe);
    > }
    >
    > -struct uprobe_map_info {
    > - struct uprobe_map_info *next;
    > - struct mm_struct *mm;
    > - unsigned long vaddr;
    > -};
    > -
    > -static inline struct uprobe_map_info *
    > -uprobe_free_map_info(struct uprobe_map_info *info)
    > +struct uprobe_map_info *uprobe_free_map_info(struct uprobe_map_info *info)
    > {
    > struct uprobe_map_info *next = info->next;
    > kfree(info);
    > return next;
    > }
    >
    > -static struct uprobe_map_info *
    > -uprobe_build_map_info(struct address_space *mapping, loff_t offset,
    > - bool is_register)
    > +struct uprobe_map_info *uprobe_build_map_info(struct address_space *mapping,
    > + loff_t offset, bool is_register)
    > {
    > unsigned long pgoff = offset >> PAGE_SHIFT;
    > struct vm_area_struct *vma;

    \
     
     \ /
      Last update: 2018-03-15 17:34    [W:4.560 / U:0.120 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site