Messages in this thread | | | Date | Thu, 15 Mar 2018 17:07:02 +0100 | From | Boris Brezillon <> | Subject | Re: [PATCH 2/3] mtd: maps: Remove print after allocation failure |
| |
Hi Arushi,
On Wed, 14 Mar 2018 21:05:17 +0530 Arushi Singhal <arushisinghal19971997@gmail.com> wrote:
> The prints after [k|v][m|z|c]alloc() functions are not needed, because > in case of failure, allocator will print their internal error prints > anyway. > > Signed-off-by: Arushi Singhal <arushisinghal19971997@gmail.com> > --- > drivers/mtd/maps/sun_uflash.c | 4 +---
And here as well some of the drivers are still printing error messages after mem allocation failures (amd76xrom, ck804xrom, esb2rom, ichxrom, vmu-flash).
Regards,
Boris
> 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/mtd/maps/sun_uflash.c b/drivers/mtd/maps/sun_uflash.c > index 1e73bba..80a253c 100644 > --- a/drivers/mtd/maps/sun_uflash.c > +++ b/drivers/mtd/maps/sun_uflash.c > @@ -62,10 +62,8 @@ int uflash_devinit(struct platform_device *op, struct device_node *dp) > } > > up = kzalloc(sizeof(struct uflash_dev), GFP_KERNEL); > - if (!up) { > - printk(KERN_ERR PFX "Cannot allocate struct uflash_dev\n"); > + if (!up) > return -ENOMEM; > - } > > /* copy defaults and tweak parameters */ > memcpy(&up->map, &uflash_map_templ, sizeof(uflash_map_templ));
-- Boris Brezillon, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com
| |