Messages in this thread | | | Date | Thu, 15 Mar 2018 17:01:37 +0100 | From | Boris Brezillon <> | Subject | Re: [PATCH 1/3] mtd: nand: Remove print after allocation failure |
| |
On Wed, 14 Mar 2018 21:05:16 +0530 Arushi Singhal <arushisinghal19971997@gmail.com> wrote:
> The prints after [k|v][m|z|c]alloc() functions are not needed, because > in case of failure, allocator will print their internal error prints > anyway. > > Signed-off-by: Arushi Singhal <arushisinghal19971997@gmail.com> > --- > drivers/mtd/nand/ams-delta.c | 1 -
You miss quite a few of them (atmel, nandsim, sunxi_nand at least, there might be others).
> 1 file changed, 1 deletion(-) > > diff --git a/drivers/mtd/nand/ams-delta.c b/drivers/mtd/nand/ams-delta.c > index 9de6572..6e7f6e0 100644 > --- a/drivers/mtd/nand/ams-delta.c > +++ b/drivers/mtd/nand/ams-delta.c > @@ -185,7 +185,6 @@ static int ams_delta_init(struct platform_device *pdev) > /* Allocate memory for MTD device structure and private data */ > this = kzalloc(sizeof(struct nand_chip), GFP_KERNEL); > if (!this) { > - printk (KERN_WARNING "Unable to allocate E3 NAND MTD device structure.\n"); > err = -ENOMEM; > goto out; > }
-- Boris Brezillon, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com
| |