Messages in this thread | | | From | David Howells <> | Subject | Re: [RFC][PATCH] sched/wait_bit: Introduce wait_var_event()/wake_up_var() | Date | Thu, 15 Mar 2018 14:45:20 +0000 |
| |
Peter Zijlstra <peterz@infradead.org> wrote:
> Does the below address things sufficiently clear?
Yep.
> +wait_queue_head_t *__var_waitqueue(void *p) > +{ > + if (BITS_PER_LONG == 64) { > + unsigned long q = (unsigned long)p; > + > + return bit_waitqueue((void *)(q & ~1), q & 1); > + } > + return bit_waitqueue(p, 0); > +}
You might be better off not using bit_waitqueue() but rather do the calculation directly since you don't actually have a bit number.
David
| |