[lkml]   [2018]   [Mar]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 00/13] staging: add drivers to support Mediatek mt7621 in gnubee-pc1
On Thu, Mar 15 2018, Dan Carpenter wrote:

> This all seems fine. Generally the requirements for staging are that it
> has a TODO, someone to work on it, and it doesn't break the build. But
> some of the patches don't have commit message and those are required and
> some of the commit messages are just the changes you have made not don't
> describe the actual code...

Thanks for having a look.
It seems odd to require detailed commit messages, when we don't require
the same level of quality in the code.
Naturally when the driver is moved out of staging a properly detailed
commit message should be added, but is that needed on the way in to
staging? At this stage I don't know much more than is already there.
After I've cleaned up the code I probably will.

For patch 01/13 you asked "what kind of device this is". The subject
line makes it clear that it is a "pcie driver". What extra detail did
you want? Would it be sufficient to just copy the subject line so that
it appears twice in the commit message?

> John Crispin's email is



> regards,
> dan carpenter
[unhandled content-type:application/pgp-signature]
 \ /
  Last update: 2018-03-15 12:05    [W:0.155 / U:1.240 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site