Messages in this thread | | | Subject | Re: [PATCH] scsi: iscsi_tcp: set BDI_CAP_STABLE_WRITES when data digest enabled | From | Lee Duncan <> | Date | Thu, 15 Mar 2018 04:37:24 -0600 |
| |
I reviewed this several days before but mistakenly replied only to the open-iscsi list.
Signed-off-by: Lee Duncan <lduncan@suse.com>
-- Lee-Man Duncan Sent from my iPhone, dude
> On Mar 14, 2018, at 10:11 PM, Martin K. Petersen <martin.petersen@oracle.com> wrote: > > >> iscsi tcp will first send out data, then calculate and send data >> digest. If we don't have BDI_CAP_STABLE_WRITES, the page cache will >> be written in spite of the on going writeback. Consequently, wrong >> digest will be got and sent to target. >> >> To fix this, set BDI_CAP_STABLE_WRITES when data digest is enabled >> in iscsi_tcp .slave_configure callback. > > Lee, Chris: Please review! > > -- > Martin K. Petersen Oracle Linux Engineering > > -- > You received this message because you are subscribed to a topic in the Google Groups "open-iscsi" group. > To unsubscribe from this topic, visit https://groups.google.com/d/topic/open-iscsi/owLIZAXfgoA/unsubscribe. > To unsubscribe from this group and all its topics, send an email to open-iscsi+unsubscribe@googlegroups.com. > To post to this group, send email to open-iscsi@googlegroups.com. > Visit this group at https://groups.google.com/group/open-iscsi. > For more options, visit https://groups.google.com/d/optout.
| |