Messages in this thread | | | From | "Winkler, Tomas" <> | Subject | RE: [PATCH v2 3/8] tpm: factor out tpm1_get_random into tpm1-cmd.c | Date | Thu, 15 Mar 2018 23:24:23 +0000 |
| |
> > On Sat, 2018-03-10 at 10:24 +0200, Tomas Winkler wrote: > > + rlength = be32_to_cpu(tpm_cmd.header.out.length); > > + if (rlength < offsetof(struct tpm_getrandom_out, rng_data) + > > + recd) { > > + total = -EFAULT; > > + break; > > + } > > + memcpy(dest, tpm_cmd.params.getrandom_out.rng_data, > recd); > > This rlength stuff can be handled with tpm_buf_length() as I do in my > pendig-for-review patch set: > > https://patchwork.kernel.org/patch/10259331/
Right, as I wrote before not sure it's good to move and change the code more than necessary at the same time. I would leave the tpm_buf_ changes after this series.
Thanks Tomas
| |