lkml.org 
[lkml]   [2018]   [Mar]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 1/2] perf record: Synthesize features before events in pipe mode
On Wed, Mar 14, 2018 at 2:22 AM, Jiri Olsa <jolsa@kernel.org> wrote:
> We need to synthesize events first, because some
> features works on top of them (on report side).
>
> Link: http://lkml.kernel.org/n/tip-vz436m6fobfz8ykmuxo8phyy@git.kernel.org
> Signed-off-by: Jiri Olsa <jolsa@kernel.org>

Works for me.
Tested-by: Stephane Eranian <eranian@google.com>

> ---
> tools/perf/builtin-record.c | 18 +++++++++++-------
> 1 file changed, 11 insertions(+), 7 deletions(-)
>
> diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c
> index d33103291b02..22ebeb92ac51 100644
> --- a/tools/perf/builtin-record.c
> +++ b/tools/perf/builtin-record.c
> @@ -754,13 +754,10 @@ static int record__synthesize(struct record *rec, bool tail)
> return 0;
>
> if (data->is_pipe) {
> - err = perf_event__synthesize_features(
> - tool, session, rec->evlist, process_synthesized_event);
> - if (err < 0) {
> - pr_err("Couldn't synthesize features.\n");
> - return err;
> - }
> -
> + /*
> + * We need to synthesize events first, because some
> + * features works on top of them (on report side).
> + */
> err = perf_event__synthesize_attrs(tool, session,
> process_synthesized_event);
> if (err < 0) {
> @@ -768,6 +765,13 @@ static int record__synthesize(struct record *rec, bool tail)
> goto out;
> }
>
> + err = perf_event__synthesize_features(tool, session, rec->evlist,
> + process_synthesized_event);
> + if (err < 0) {
> + pr_err("Couldn't synthesize features.\n");
> + return err;
> + }
> +
> if (have_tracepoints(&rec->evlist->entries)) {
> /*
> * FIXME err <= 0 here actually means that
> --
> 2.13.6
>

\
 
 \ /
  Last update: 2018-03-14 19:45    [W:0.107 / U:1.968 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site