Messages in this thread | | | From | Andy Shevchenko <> | Date | Wed, 14 Mar 2018 19:41:27 +0200 | Subject | Re: [PATCH 1/2, pci] pci: Addition of PCI_DEV_FLAGS_QUIET_PCI_REALIGN attribute to the PCI subsystem |
| |
On Wed, Mar 14, 2018 at 6:34 PM, Desnes A. Nunes do Rosario <desnesn@linux.vnet.ibm.com> wrote: > Add PCI_DEV_FLAGS_QUIET_PCI_REALIGN to pci_dev_flags and use it to > silent PCI realignment messages if the flag is turned on by a driver.
It doesn't explain "Why?" Why the driver needs that?
Another approach is to increase level of the message. Would it be accepted by you (in case Bjorn agrees)?
> --- a/include/linux/pci.h > +++ b/include/linux/pci.h > @@ -205,6 +205,8 @@ enum pci_dev_flags { > PCI_DEV_FLAGS_NO_FLR_RESET = (__force pci_dev_flags_t) (1 << 10), > /* Don't use Relaxed Ordering for TLPs directed at this device */ > PCI_DEV_FLAGS_NO_RELAXED_ORDERING = (__force pci_dev_flags_t) (1 << 11), > + /* Silent PCI resource realignment messages */ > + PCI_DEV_FLAGS_QUIET_PCI_REALIGN = (__force pci_dev_flags_t) (1 << 12),
I would rather name it _NO_PCI_REALIGN_MSG
> };
-- With Best Regards, Andy Shevchenko
| |