lkml.org 
[lkml]   [2018]   [Mar]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 2/3] mtd: maps: Remove print after allocation failure
    Date
    The prints after [k|v][m|z|c]alloc() functions are not needed, because
    in case of failure, allocator will print their internal error prints
    anyway.

    Signed-off-by: Arushi Singhal <arushisinghal19971997@gmail.com>
    ---
    drivers/mtd/maps/sun_uflash.c | 4 +---
    1 file changed, 1 insertion(+), 3 deletions(-)

    diff --git a/drivers/mtd/maps/sun_uflash.c b/drivers/mtd/maps/sun_uflash.c
    index 1e73bba..80a253c 100644
    --- a/drivers/mtd/maps/sun_uflash.c
    +++ b/drivers/mtd/maps/sun_uflash.c
    @@ -62,10 +62,8 @@ int uflash_devinit(struct platform_device *op, struct device_node *dp)
    }

    up = kzalloc(sizeof(struct uflash_dev), GFP_KERNEL);
    - if (!up) {
    - printk(KERN_ERR PFX "Cannot allocate struct uflash_dev\n");
    + if (!up)
    return -ENOMEM;
    - }

    /* copy defaults and tweak parameters */
    memcpy(&up->map, &uflash_map_templ, sizeof(uflash_map_templ));
    --
    2.7.4
    \
     
     \ /
      Last update: 2018-03-14 16:37    [W:3.589 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site