lkml.org 
[lkml]   [2018]   [Mar]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2 5/5] iommu/amd - Add a debugfs entry to specify a IOMMU device table entry
From
Date
On 03/13/2018 03:56 PM, Andy Shevchenko wrote:
> On Tue, Mar 13, 2018 at 8:54 PM, Gary R Hook <gary.hook@amd.com> wrote:
>> On 03/13/2018 12:20 PM, Andy Shevchenko wrote:
>
>>>> + } else if (obuf[0] == '0' && obuf[1] == 'x') {
>>>> + n = sscanf(obuf, "%x", &amd_iommu_devid);
>>>> + } else {
>>>> + n = sscanf(obuf, "%d", &amd_iommu_devid);
>>>> + }
>
>>> kstrtoint() ?
>
>> I see various mechanisms for this sort of thing, and simply chose one.
>> Am happy to use whatever is preferred.
>
> sscanf() has an enormous overhead for cases like this.
>
> simple
>
> ret = kstrtoint();
> if (ret)
> ... do error handling ...
>
>

Gotcha. Fixed.

Thanks,
Gary

\
 
 \ /
  Last update: 2018-03-14 16:25    [W:0.101 / U:3.592 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site