Messages in this thread | | | Date | Wed, 14 Mar 2018 14:58:04 +0100 | From | Greg KH <> | Subject | Re: [PATCH] serial: samsung: macros with complex values should be enclosed in parentheses |
| |
On Wed, Mar 14, 2018 at 11:17:05AM +0900, YOUNGKEUN OH wrote: > Cleanup checkpatch error: > ERROR: Macros with complex values should be enclosed in parentheses > > Signed-off-by: YOUNGKEUN OH <y.k.oh@samsung.com> > --- > drivers/tty/serial/samsung.c | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) > > diff --git a/drivers/tty/serial/samsung.c b/drivers/tty/serial/samsung.c > index 3f2f8c1..da9bddb1 100644 > --- a/drivers/tty/serial/samsung.c > +++ b/drivers/tty/serial/samsung.c > @@ -1455,7 +1455,7 @@ static int __init s3c24xx_serial_console_init(void) > } > console_initcall(s3c24xx_serial_console_init); > > -#define S3C24XX_SERIAL_CONSOLE &s3c24xx_serial_console > +#define S3C24XX_SERIAL_CONSOLE (&s3c24xx_serial_console)
That's not a complex macro!
Please use checkpatch as a hint, not the "truth".
thanks,
greg k-h
| |