Messages in this thread | | | From | Stephan Mueller <> | Subject | Re: [PATCH] crypto: ctr: avoid VLA use | Date | Wed, 14 Mar 2018 14:52:29 +0100 |
| |
Am Mittwoch, 14. März 2018, 14:46:29 CET schrieb Salvatore Mesoraca:
Hi Salvatore,
> 2018-03-14 14:31 GMT+01:00 Stephan Mueller <smueller@chronox.de>: > > Am Mittwoch, 14. März 2018, 14:17:30 CET schrieb Salvatore Mesoraca: > > > > Hi Salvatore, > > > >> if (walk.nbytes) { > >> > >> - crypto_ctr_crypt_final(&walk, child); > >> - err = blkcipher_walk_done(desc, &walk, 0); > >> + err = crypto_ctr_crypt_final(&walk, child); > >> + err = blkcipher_walk_done(desc, &walk, err); > > > > I guess you either want to handle the error from crypto_ctr_crypt_final or > > do an err |= blkcipher_walk_done. > > I think that blkcipher_walk_done handles and returns the error for me. > Am I wrong?
You are right as you want to finalize the crypto operation even though the encryption fails.
Please disregard my comment. > > Best regards, > > Salvatore
Ciao Stephan
| |