Messages in this thread | | | Date | Wed, 14 Mar 2018 08:13:05 -0400 | From | okaya@codeauro ... | Subject | Re: [PATCH 7/7] ixgbevf: eliminate duplicate barriers on weakly-ordered archs |
| |
On 2018-03-14 01:08, Timur Tabi wrote: > On 3/13/18 10:20 PM, Sinan Kaya wrote: >> +/* Assumes caller has executed a write barrier to order memory and >> device >> + * requests. >> + */ >> static inline void ixgbevf_write_tail(struct ixgbevf_ring *ring, u32 >> value) >> { >> - writel(value, ring->tail); >> + writel_relaxed(value, ring->tail); >> } > > Why not put the wmb() in this function, or just get rid of the wmb() > in the rest of the file and keep this as writel? That way, you can > avoid the comment and the risk that comes with it.
Sure, both solutions will work. I want to see what the maintainer prefers. I can repost accordingly.
| |