lkml.org 
[lkml]   [2018]   [Mar]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/3] usb: host: pci: introduce PCI vendor ID for Netlogic
On Wed, Mar 14, 2018 at 12:36:17PM +0100, Richard Leitner wrote:
>
> On 03/14/2018 11:48 AM, Greg KH wrote:
> > On Wed, Mar 14, 2018 at 11:29:32AM +0100, Richard Leitner wrote:
> >> From: Richard Leitner <richard.leitner@skidata.com>
> >>
> >> Replace the hardcoded PCI vendor ID of Netlogic with a definition in
> >> pci_ids.h
> >
> > Why? It's only being used in one file, so it should not be in
> > pci_ids.h, right?
>
> It's also used as PCI_VENDOR_NETLOGIC in arch/mips/netlogic/xlp/.
>
> Should this be replaced with PCI_VENDOR_ID_NETLOGIC from pci_ids.h?

Yes, if you are going to add it to pci_ids.h, it had better be used by
multiple files, otherwise it does not belong in there.

thanks,

greg k-h

\
 
 \ /
  Last update: 2018-03-14 12:50    [W:0.040 / U:0.744 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site