[lkml]   [2018]   [Mar]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] Update rf_type_definition
On Wed, Feb 07, 2018 at 06:23:34AM +0900, wrote:
> From: Kangmin Park <>

Your subject line should say the subsystem and driver you are modifying.
Look at the hundreds of other patches on the mailing lists for examples
of how to properly format it.

> enum RT_RF_TYPE_DEFINITION on rtl8723bs/include/rtw_rf.h
> is different from enum tag_HAL_RF_Type_Definition on
> rtl8723bs/include/HalVerDef.h
> So, update them to be the same reference from
> enum rf_type on rtlwifi/wifi.h which recent version.
> As a result, ODM_RF_TYPE_E needs to be updated as well
> Therefore, it is updated reference from enum odm_rf_type
> on rtlwifi/phydm/phydm_pre_define.h too.
> And update some additional code to check more
> chip versions that resulted from it.
> Also, fixed some space required errors and
> line over 80 characters warnings by

When you say "also", that means you should be splitting this patch up
into multpile patches. Please only do one-thing-per-patch.

This should be a patch series, please fix it up and resend.


greg k-h

 \ /
  Last update: 2018-03-14 12:43    [W:0.061 / U:1.948 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site