lkml.org 
[lkml]   [2018]   [Mar]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH v2 1/2] irqchip: stm32: Optimizes and cleans up stm32-exti irq_domain
    From
    Date
    Radoslaw,

    On 23/02/18 08:42, Thomas Gleixner wrote:
    > Radoslaw,
    >
    > On Fri, 23 Feb 2018, Radoslaw Pietrzyk wrote:
    >
    >> - discards setting handle_simple_irq handler for hierarchy interrupts
    >> - removes acking in chained irq handler as this is done by
    >> irq_chip itself inside handle_edge_irq
    >> - removes unneeded irq_domain_ops.xlate callback
    >
    > if that's all functionally correct, then this is a nice cleanup. Though
    > from the above changelog its hard to tell because it merily tells WHAT the
    > patch does, but not WHY. The WHY is the important information for a
    > reviewer who is not familiar with the particular piece of code/hardware.
    >
    > Can you please amend the changelog with proper explanations why a
    > particular piece of code is not needed or has to be changed to something
    > else?

    Any update on this? I'd like to queue this for 4.17, but Thomas'
    comments should be addressed before that happens. Ca you please respin a
    version with a better change log and the various review tags?

    Thanks,

    M.
    --
    Jazz is not dead. It just smells funny...

    \
     
     \ /
      Last update: 2018-03-14 12:10    [W:3.120 / U:0.100 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site