Messages in this thread | | | From | Geert Uytterhoeven <> | Date | Wed, 14 Mar 2018 09:21:44 +0100 | Subject | Re: [PATCH v2 02/11] media: vsp1: Remove packed attributes from aligned structures |
| |
On Tue, Mar 13, 2018 at 7:05 PM, Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> wrote: > The use of the packed attribute can cause a performance penalty for > all accesses to the struct members, as the compiler will assume that the > structure has the potential to have an unaligned base. > > These structures are all correctly aligned and contain no holes, thus > the attribute is redundant and negatively impacts performance, so we > remove the attributes entirely. > > Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |