Messages in this thread | | | Subject | Re: [PATCH v2 1/5] iommu/amd - Add debugfs support | From | Gary R Hook <> | Date | Wed, 14 Mar 2018 17:23:40 -0500 |
| |
On 03/14/2018 10:29 AM, Andy Shevchenko wrote: > On Wed, Mar 14, 2018 at 5:24 PM, Gary R Hook <gary.hook@amd.com> wrote: >> On 03/13/2018 03:23 PM, Andy Shevchenko wrote: > >>>>>> +#include <linux/pci.h> >>>>>> +#include <linux/iommu.h> >>>>>> +#include <linux/debugfs.h> > >>>>> Keep in order? > >>>> What order would that be? These few needed files are listed in the same >>>> order as which they appear in amd_iommu.c. I'm gonna need a preference >>>> spelled out, please (and a rationale, so I may better understand). > >>> To increase readability and avoid potential header duplication (here >>> is can bus protocol implementation where the problem exists for real, >>> even in new code!) > >> With all due respect, I don't find that you clearly answered my question. > > Alphabetical order I meant.
Thank you very much.
Gary
| |