lkml.org 
[lkml]   [2018]   [Mar]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.15 088/146] x86-64/realmode: Add instruction suffix
    Date
    4.15-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Jan Beulich <JBeulich@suse.com>

    commit 8554004a0231dedf44d4d62147fb3d6a6db489aa upstream.

    Omitting suffixes from instructions in AT&T mode is bad practice when
    operand size cannot be determined by the assembler from register
    operands, and is likely going to be warned about by upstream GAS in the
    future (mine does already). Add the single missing suffix here.

    Signed-off-by: Jan Beulich <jbeulich@suse.com>
    Acked-by: Thomas Gleixner <tglx@linutronix.de>
    Cc: Andy Lutomirski <luto@kernel.org>
    Cc: Borislav Petkov <bp@alien8.de>
    Cc: Brian Gerst <brgerst@gmail.com>
    Cc: Denys Vlasenko <dvlasenk@redhat.com>
    Cc: H. Peter Anvin <hpa@zytor.com>
    Cc: Josh Poimboeuf <jpoimboe@redhat.com>
    Cc: Linus Torvalds <torvalds@linux-foundation.org>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Link: http://lkml.kernel.org/r/5A8AF5F602000078001A9230@prv-mh.provo.novell.com
    Signed-off-by: Ingo Molnar <mingo@kernel.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    arch/x86/realmode/rm/trampoline_64.S | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/arch/x86/realmode/rm/trampoline_64.S
    +++ b/arch/x86/realmode/rm/trampoline_64.S
    @@ -102,7 +102,7 @@ ENTRY(startup_32)
    * don't we'll eventually crash trying to execute encrypted
    * instructions.
    */
    - bt $TH_FLAGS_SME_ACTIVE_BIT, pa_tr_flags
    + btl $TH_FLAGS_SME_ACTIVE_BIT, pa_tr_flags
    jnc .Ldone
    movl $MSR_K8_SYSCFG, %ecx
    rdmsr

    \
     
     \ /
      Last update: 2018-03-13 17:42    [W:4.160 / U:0.080 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site