Messages in this thread | | | From | Arnd Bergmann <> | Date | Tue, 13 Mar 2018 15:27:18 +0100 | Subject | Re: [PATCH 2/2] cpufreq: scmi: add thermal dependency |
| |
On Tue, Mar 13, 2018 at 3:09 PM, Sudeep Holla <sudeep.holla@arm.com> wrote: > > > On 13/03/18 11:45, Arnd Bergmann wrote: >> A built-in scmi cpufreq driver cannot link against a modular >> thermal framework: >> >> drivers/cpufreq/scmi-cpufreq.o: In function `scmi_cpufreq_ready': >> scmi-cpufreq.c:(.text+0x40): undefined reference to `of_cpufreq_cooling_register' >> drivers/cpufreq/scmi-cpufreq.o: In function `scmi_cpufreq_exit': >> scmi-cpufreq.c:(.text+0x88): undefined reference to `cpufreq_cooling_unregister' >> >> This adds a Kconfig dependency that makes sure this configuration >> is not possible, while allowing all configurations that can work. >> Note that disabling CPU_THERMAL means we don't care about the >> THERMAL dependency. >> > > This newly added entry is only in arm-soc linux-next. Let me know if you > want pull request with other possible fixes or you want to merge > directly as it might be need to suppress these errors in your build > system. For now I assume you will merge this directly in your tree, so > > Acked-by: Sudeep Holla <sudeep.holla@arm.com>
I've applied it into my next/drivers branch now. Thanks for the Ack. I assume the cpufreq maintainers will pick up the other one. I'm not sure why I didn't run into that problem earlier, but today I saw both for the first time.
Arnd
| |