Messages in this thread | | | Date | Tue, 13 Mar 2018 15:03:03 +0100 | From | Maxime Ripard <> | Subject | Re: [linux-sunxi] Re: [PATCH v2 6/6] ASoC: sun4i-i2s: Add support for loopback |
| |
On Tue, Mar 13, 2018 at 01:39:44PM +0000, Chris Obbard wrote: > >> +- loopback: if this property is present then the dai is configured in > >> + loopback mode where the output fifo is redirected to the input > >> + fifo. > > > > This really doesn't seem like something that ought to go into the DT > > and hence ABI given that there's obviously no reason to use this in > > production. Just make it be a #define in the code or something. > > It would be nice to have this as an optional devicetree property so > when testing JACK latency etc I don't have to manually re-compile a > kernel...
Another one might also argue that having to recompile the DT and reflash the whole firmware or EEPROM is overkill for just testing JACK latency.
Can't we create a module parameter for it?
Maxime
-- Maxime Ripard, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com [unhandled content-type:application/pgp-signature] | |