Messages in this thread Patch in this message | | | From | "Maciej S. Szmigiero" <> | Subject | [PATCH v3 9/9] x86/microcode/AMD: be more tolerant of late parse failures in late loader | Date | Tue, 13 Mar 2018 22:07:26 +0100 |
| |
The early loader just ends its microcode container file processing when it is unable to parse some patch section, but keeps the already read patches from this file for their eventual application.
We can do the same in the late loader - we'll just return an error if we are unable to parse any patches. Note that we already do silently skip patches in the late loader for smaller issues like lack of an equivalence table entry, family-size mismatch or an unsupported chipset match type.
Signed-off-by: Maciej S. Szmigiero <mail@maciej.szmigiero.name> --- arch/x86/kernel/cpu/microcode/amd.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/arch/x86/kernel/cpu/microcode/amd.c b/arch/x86/kernel/cpu/microcode/amd.c index 78e698fcd3ce..a098780b0847 100644 --- a/arch/x86/kernel/cpu/microcode/amd.c +++ b/arch/x86/kernel/cpu/microcode/amd.c @@ -729,13 +729,15 @@ static enum ucode_state __load_microcode_amd(u8 family, const u8 *data, while (leftover) { crnt_size = verify_and_add_patch(family, fw, leftover); if (crnt_size < 0) - return ret; + break; fw += crnt_size; leftover -= crnt_size; + + ret = UCODE_OK; } - return UCODE_OK; + return ret; } static enum ucode_state
| |