lkml.org 
[lkml]   [2018]   [Mar]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v3 01/11] PCI/P2PDMA: Support peer-to-peer memory


On 12/03/18 09:28 PM, Sinan Kaya wrote:
> Maybe, dev parameter should also be struct pci_dev so that you can get rid of
> all to_pci_dev() calls in this code including find_parent_pci_dev() function.

No, this was mentioned in v2. find_parent_pci_dev is necessary because
the calling drivers aren't likely to have a bunch of struct pci_dev's
for all the devices they are working with lying around. It's a much
nicer from an API stand point to take struct devs and not worth it just
to have a PCI API only taking struct pci_devs.

Logan

\
 
 \ /
  Last update: 2018-03-13 19:40    [W:0.095 / U:0.748 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site