Messages in this thread | | | Subject | Re: [pci PATCH v5 3/4] ena: Migrate over to unmanaged SR-IOV support | From | David Woodhouse <> | Date | Tue, 13 Mar 2018 08:12:52 +0000 |
| |
On Mon, 2018-03-12 at 10:23 -0700, Alexander Duyck wrote: > > - .sriov_configure = ena_sriov_configure, > +#ifdef CONFIG_PCI_IOV > + .sriov_configure = pci_sriov_configure_simple, > +#endif > };
I'd like to see that ifdef go away, as discussed. I agree that just #define pci_sriov_configure_simple NULL should suffice. As Christoph points out, it's not going to compile if people try to just invoke it directly.
I'd also *really* like to see a way to enable this for PFs which don't have (and don't need) a driver. We seem to have lost that along the way. [unhandled content-type:application/x-pkcs7-signature] | |