Messages in this thread | | | Date | Mon, 12 Mar 2018 08:53:07 +0100 | From | Ingo Molnar <> | Subject | Re: [PATCH RESEND v5] perf/core: Fix installing arbitrary cgroup event into cpu |
| |
* linxiulei@gmail.com <linxiulei@gmail.com> wrote:
> /* > * Because cgroup events are always per-cpu events, > * this will always be called from the right CPU. > */
> + /* > + * if only the cgroup is running on this cpu > + * and cpuctx->cgrp == NULL (otherwise it would've > + * been set with running cgroup), we put this cgroup > + * into cpu context. Or it would case mismatch in > + * following cgroup events at event_filter_match() > + */
Beyond making sure that what you comment on makes sense, please also follow existing comment style, which I quoted above.
There's 3 separate mistakes in that paragraph alone.
Thanks,
Ingo
| |