Messages in this thread | | | Date | Mon, 12 Mar 2018 20:14:16 +0100 | From | Dominik Brodowski <> | Subject | Re: [RFC PATCH 01/35] syscalls: define goal to not call sys_xyzzy() from within the kernel |
| |
On Sun, Mar 11, 2018 at 03:24:01PM +0000, Andy Lutomirski wrote: > On Sun, Mar 11, 2018 at 10:55 AM, Dominik Brodowski > <linux@dominikbrodowski.net> wrote: > > + > > +/* > > + * The kernel should not use call syscalls (i.e., sys_xyzyyz()) directly. > > + * Instead, use one of the following functions which work equivalent to > > + * the syscall they are named for. > > "Instead, use one of the functions which work equivalently, e.g. do_xysyyz()"
On Mon, Mar 12, 2018 at 08:27:49AM +0100, Ingo Molnar wrote: > The previous sentence has a typo as well, should be: > > * Kernel code should not call syscalls (i.e., sys_xyzyyz()) directly.
Thanks for your feedback. Here's what I will do for v2, unless you find more typos or areas for improvement:
/* * Kernel code should not call syscalls (i.e., sys_xyzyyz()) directly. * Instead, use one of the functions which work equivalently, such as * the ksys_xyzyyz() functions prototyped below. */
Thanks, Dominik
| |