Messages in this thread | | | From | 李書帆 <> | Date | Mon, 12 Mar 2018 19:26:07 +0800 | Subject | Re: [PATCH] Fixes: 8f9439022648("staging: typec: modify parameter of tcpci_irq") |
| |
Hi Greg,
2018-03-12 19:07 GMT+08:00 Greg KH <greg@kroah.com>: > On Mon, Mar 12, 2018 at 05:46:42PM +0800, ShuFan Lee wrote: >> From: ShuFan Lee <shufan_lee@richtek.com> > > Your subject is odd, that line should be below, in the signed-off-by: > area, not as the subject of the patch :( > > Can you fix this up and resend? Yes. If I understand correctly, the title should be like staging: typec: modify parameter of tcpci_irq and the "Fixes" tag should be put in the signed-off-by area.
Should it be in the beginning of the area: Fixes: 8f9439022648("staging: typec: handle vendor defined part and modify drp toggling flow") Signed-off-by: xxx
or the end of the area? Signed-off-by: xxx Fixes: 8f9439022648("staging: typec: handle vendor defined part and modify drp toggling flow")
> > thanks, > > greg k-h
-- Best Regards, 書帆
| |