Messages in this thread | | | Date | Mon, 12 Mar 2018 18:40:54 +0800 | From | JeffyChen <> | Subject | Re: [PATCH v5 1/3] Input: gpio-keys - add support for wakeup event action |
| |
Hi Dmitry,
Thanks for your reply.
On 03/11/2018 02:15 AM, Dmitry Torokhov wrote:>> +static int gpio_keys_enable_wakeup(struct gpio_button_data *bdata) > These new helpers need to be __maybe_unused in case we compile on system > without suspend support. > > I also wanted a bit more of error handling, so I ended up with the > version of the patch below. Can you please try it and let me know if I > broke it.
sure, the patch you sent works :)
Tested-by: Jeffy Chen <jeffy.chen@rock-chips.com>
> > Thanks. > > -- Dmitry > > Input: gpio-keys - add support for wakeup event action > > From: Jeffy Chen <jeffy.chen@rock-chips.com> > > Add support for specifying event actions to trigger wakeup when using > the gpio-keys input device as a wakeup source. > > This would allow the device to configure when to wakeup the system. For > example a gpio-keys input device for pen insert, may only want to wakeup > the system when ejecting the pen. > > Suggested-by: Brian Norris <briannorris@chromium.org> > Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com> > Reviewed-by: Rob Herring <robh@kernel.org> > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
| |