Messages in this thread | | | Subject | Re: [PATCH v9] mmc: Export host capabilities to debugfs. | From | Harish Jenny K N <> | Date | Mon, 12 Mar 2018 15:57:12 +0530 |
| |
On Monday 12 March 2018 03:37 PM, Andy Shevchenko wrote: > On Mon, 2018-03-12 at 10:01 +0530, Harish Jenny K N wrote: >> This patch exports the host capabilities to debugfs >> >> This idea of sharing host capabilities over debugfs >> came up from Abbas Raza <Abbas_Raza@mentor.com> >> Earlier discussions: >> https://lkml.org/lkml/2018/3/5/357 >> https://www.spinics.net/lists/linux-mmc/msg48219.html >> > Address below minors and, FWIW, take mine > > Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Thanks.
> >> + for_each_set_bit(bit, (const unsigned long *)&caps, >> BITS_PER_LONG) >> + for_each_set_bit(bit, (const unsigned long *)&caps2, >> BITS_PER_LONG) > Explicit casting is not needed anymore in both cases. >
I will address these. Before sending new patch , I would like to inform that I have been sending this patch with the following checkpatch warning, just to keep it same as other usages of debugfs_create_file in the drivers/mmc/core/debugfs.c file.
WARNING:SYMBOLIC_PERMS: Symbolic permissions 'S_IRUSR' are not preferred. Consider using octal permissions '0400'.
Do I need to address this or keep it same as S_IRUSR ?
Thanks, Harish Jenny K N
| |