Messages in this thread | | | Subject | Re: [PATCH] video: fbdev: via: remove VLA usage | From | "Gustavo A. R. Silva" <> | Date | Mon, 12 Mar 2018 22:29:27 -0500 |
| |
On 03/09/2018 05:02 AM, Emil Velikov wrote: > On 9 March 2018 at 10:59, Eric Engestrom <eric.engestrom@imgtec.com> wrote: >> On Thursday, 2018-03-08 11:39:49 -0600, Gustavo A. R. Silva wrote: >>> In preparation to enabling -Wvla, remove VLA usage. >>> >>> Also, fixed as part of the directive to remove all VLAs from >>> the kernel: https://lkml.org/lkml/2018/3/7/621 >>> >>> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> >> >> Sorry for my reply on v1, I missed that Emil already replied to another >> post of the same patch (side note on that, making use of `-vX` and >> `--in-reply-to` helps track the evolution of patches) >>
Yep. I know. It is just that some people prefer vX in a new thread. Anyway, I will take this into account for the next time.
>> This looks good to me: >> Reviewed-by: Eric Engestrom <eric.engestrom@imgtec.com> >> > Same here > Reviewed-by: Emil Velikov <emil.velikov@collabora.com> > > -Emil >
Thanks for reviewing it, guys. -- Gustavo A. R. Silva
| |