Messages in this thread | | | Subject | Re: [PATCH 1/5] arm64: dts: allwinner: a64: Add i2c0 pins | From | André Przywara <> | Date | Tue, 13 Mar 2018 01:35:39 +0000 |
| |
On 12/03/18 16:10, Harald Geyer wrote: > Add the proper pin group node to reference in board files. > > Signed-off-by: Harald Geyer <harald@ccbib.org>
That looks correct to me, so:
Reviewed-by: Andre Przywara <andre.przywara@arm.com>
But out of curiosity, what is this used for? In patch 5/5 I see it being used, but without a clue for what? Shouldn't enabling an I2C node be accompanied by some child node, presenting the device on the bus? I guess this I2C is not on some kind of "header" on that laptop?
Cheers, Andre.
> --- > arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > index 1b6dc31e7d91..64e452a758fa 100644 > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > @@ -309,6 +309,11 @@ > interrupt-controller; > #interrupt-cells = <3>; > > + i2c0_pins: i2c0_pins { > + pins = "PH0", "PH1"; > + function = "i2c0"; > + }; > + > i2c1_pins: i2c1_pins { > pins = "PH2", "PH3"; > function = "i2c1"; >
| |