lkml.org 
[lkml]   [2018]   [Mar]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [RFC PATCH 13/35] syscalls: do not call sys_ioperm() within the kernel
On Sun, Mar 11, 2018 at 10:55 AM, Dominik Brodowski
<linux@dominikbrodowski.net> wrote:
> While at it, use SYSCALL_DEFINE3() instead of a hand-crafted syscall
> definition.

Great!

> static void complete_change_console(struct vc_data *vc);
> @@ -420,12 +420,12 @@ int vt_ioctl(struct tty_struct *tty,
> ret = -EINVAL;
> break;
> }
> - ret = sys_ioperm(arg, 1, (cmd == KDADDIO)) ? -ENXIO : 0;
> + ret = ksys_ioperm(arg, 1, (cmd == KDADDIO)) ? -ENXIO : 0;
> break;
>
> case KDENABIO:
> case KDDISABIO:
> - ret = sys_ioperm(GPFIRST, GPNUM,
> + ret = ksys_ioperm(GPFIRST, GPNUM,
> (cmd == KDENABIO)) ? -ENXIO : 0;
> break;
> #endif

I wonder if we can just delete this code.

\
 
 \ /
  Last update: 2018-03-11 16:20    [W:0.258 / U:0.284 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site