Messages in this thread | | | From | "Tautschnig, Michael" <> | Subject | Re: [PATCH] x86: always use SYSCALL_DEFINE* | Date | Sat, 10 Mar 2018 20:59:46 +0000 |
| |
On 10 Mar 2018, at 20:55, Tautschnig, Michael <tautschn@amazon.co.uk> wrote: > > All syscall arguments are passed in as types of the same byte size as > unsigned long (width of full registers). Using a smaller type without a > cast may result in losing bits of information. SYSCALL_DEFINE* introduce > adequate type casts. All definitions of syscalls in x86 except for those > patched here have already been using the appropriate SYSCALL_DEFINE*. [...]
Additional context: I had previously made an attempt to ensure type consistency of sys_ioperm as "Syscall arguments are unsigned long (full registers)" (https://lkml.org/lkml/2016/7/4/336). I hope the new proposal is more acceptable.
Best, Michael
Amazon Web Services UK Limited. Registered in England and Wales with registration number 08650665 with its registered office at 1 Principal Place, Worship Street, London, EC2A 2FA, United Kingdom.
| |