lkml.org 
[lkml]   [2018]   [Mar]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RESEND PATCH v4 2/2] net: ethernet: nixge: Add support for National Instruments XGE netdev
Hi Moritz

> - Consistency for NIXGE_MDIO_CXX_READ constants

> +#define NIXGE_MDIO_CLAUSE45 BIT(12)
> +#define NIXGE_MDIO_CLAUSE22 0
> +#define NIXGE_MDIO_OP(n) (((n) & 0x3) << 10)
> +#define NIXGE_MDIO_OP_ADDRESS 0
> +#define NIXGE_MDIO_OP_WRITE BIT(0)
> +#define NIXGE_MDIO_C45_READ (BIT(1) | BIT(0))
> +#define NIXGE_MDIO_C22_WRITE BIT(0)
> +#define NIXGE_MDIO_C22_READ BIT(1)

Thanks for making READ consistent. But what about WRITE? I'd suggest
you don't just blindly follow comments, but think about them.

Andrew

\
 
 \ /
  Last update: 2018-03-01 21:13    [W:2.351 / U:0.576 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site