Messages in this thread | | | Subject | Re: [RFC PATCH v4 1/7] xen/pvh: Split CONFIG_XEN_PVH into CONFIG_PVH and CONFIG_XEN_PVH | From | Maran Wilson <> | Date | Thu, 1 Mar 2018 09:24:13 -0800 |
| |
On 3/1/2018 7:17 AM, Paolo Bonzini wrote: > On 01/03/2018 16:02, Boris Ostrovsky wrote: >> On 02/28/2018 01:27 PM, Maran Wilson wrote: >>> diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig >>> index eb7f43f23521..fa7cd0305125 100644 >>> --- a/arch/x86/Kconfig >>> +++ b/arch/x86/Kconfig >>> @@ -791,6 +791,14 @@ config KVM_GUEST >>> underlying device model, the host provides the guest with >>> timing infrastructure such as time of day, and system time >>> >>> +config PVH >>> + bool "Support for running PVH guests" >>> + depends on KVM_GUEST || XEN >> >> Not sure about XEN part. PVH is selected by XEN_PVH for Xen. >> >> What about introducing KVM_GUEST_PVH that will select PVH and then drop >> dependency here? > That is, "config KVM_GUEST_PVH" "depends on KVM_GUEST" "select PVH". > Sounds good to me.
OK, will do.
Thanks, -Maran
> Paolo > >> -boris >> >>> + def_bool n >>> + ---help--- >>> + This option enables the PVH entry point for guest virtual machines >>> + as specified in the x86/HVM direct boot ABI. >>> + >>> >> >>> diff --git a/arch/x86/xen/Kconfig b/arch/x86/xen/Kconfig >>> index f605825a04ab..021c8591c3c0 100644 >>> --- a/arch/x86/xen/Kconfig >>> +++ b/arch/x86/xen/Kconfig >>> @@ -77,8 +77,9 @@ config XEN_DEBUG_FS >>> Enabling this option may incur a significant performance overhead. >>> >>> config XEN_PVH >>> - bool "Support for running as a PVH guest" >>> + bool "Support for running as a Xen PVH guest" >>> depends on XEN && XEN_PVHVM && ACPI >>> # Pre-built page tables are not ready to handle 5-level paging. >>> depends on !X86_5LEVEL >>> + select PVH >>> def_bool n
| |