lkml.org 
[lkml]   [2018]   [Mar]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v3 08/13] remoteproc: add prepare and unprepare ops
    Date
    On some SoC architecture, it is needed to enable HW like
    clock, bus, regulator, memory region... before loading
    co-processor firmware.

    This patch introduces prepare and unprepare ops to execute
    platform specific function before firmware loading and after
    stop execution.

    Signed-off-by: Loic Pallardy <loic.pallardy@st.com>
    ---
    drivers/remoteproc/remoteproc_core.c | 20 +++++++++++++++++++-
    include/linux/remoteproc.h | 4 ++++
    2 files changed, 23 insertions(+), 1 deletion(-)

    diff --git a/drivers/remoteproc/remoteproc_core.c b/drivers/remoteproc/remoteproc_core.c
    index 7a500cb..0ebbc4f 100644
    --- a/drivers/remoteproc/remoteproc_core.c
    +++ b/drivers/remoteproc/remoteproc_core.c
    @@ -1058,12 +1058,22 @@ static int rproc_fw_boot(struct rproc *rproc, const struct firmware *fw)
    return ret;
    }

    + /* Prepare rproc for firmware loading if needed */
    + if (rproc->ops->prepare) {
    + ret = rproc->ops->prepare(rproc);
    + if (ret) {
    + dev_err(dev, "can't prepare rproc %s: %d\n",
    + rproc->name, ret);
    + goto disable_iommu;
    + }
    + }
    +
    rproc->bootaddr = rproc_get_boot_addr(rproc, fw);

    /* load resource table */
    ret = rproc_load_rsc_table(rproc, fw);
    if (ret)
    - goto disable_iommu;
    + goto unprepare_rproc;

    /* reset max_notifyid */
    rproc->max_notifyid = -1;
    @@ -1086,6 +1096,10 @@ static int rproc_fw_boot(struct rproc *rproc, const struct firmware *fw)
    kfree(rproc->cached_table);
    rproc->cached_table = NULL;
    rproc->table_ptr = NULL;
    +unprepare_rproc:
    + /* release HW resources if needed */
    + if (rproc->ops->unprepare)
    + rproc->ops->unprepare(rproc);
    disable_iommu:
    rproc_disable_iommu(rproc);
    return ret;
    @@ -1331,6 +1345,10 @@ void rproc_shutdown(struct rproc *rproc)
    /* clean up all acquired resources */
    rproc_resource_cleanup(rproc);

    + /* release HW resources if needed */
    + if (rproc->ops->unprepare)
    + rproc->ops->unprepare(rproc);
    +
    rproc_disable_iommu(rproc);

    /* Free the copy of the resource table */
    diff --git a/include/linux/remoteproc.h b/include/linux/remoteproc.h
    index 4aa30bd..dcfa601 100644
    --- a/include/linux/remoteproc.h
    +++ b/include/linux/remoteproc.h
    @@ -333,6 +333,8 @@ struct rproc_mem_entry {

    /**
    * struct rproc_ops - platform-specific device handlers
    + * @prepare: prepare device for code loading
    + * @unprepare: unprepare device after stop
    * @start: power on the device and boot it
    * @stop: power off the device
    * @kick: kick a virtqueue (virtqueue id given as a parameter)
    @@ -345,6 +347,8 @@ struct rproc_mem_entry {
    * @get_boot_addr: get boot address to entry point specified in firmware
    */
    struct rproc_ops {
    + int (*prepare)(struct rproc *rproc);
    + int (*unprepare)(struct rproc *rproc);
    int (*start)(struct rproc *rproc);
    int (*stop)(struct rproc *rproc);
    void (*kick)(struct rproc *rproc, int vqid);
    --
    1.9.1
    \
     
     \ /
      Last update: 2018-03-01 17:27    [W:4.303 / U:0.320 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site