lkml.org 
[lkml]   [2018]   [Mar]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 1/2] ARM: dts: imx6: RDU2: Add RAVE SP device
On Tue, Feb 27, 2018 at 10:31 PM, Shawn Guo <shawnguo@kernel.org> wrote:
> On Mon, Feb 26, 2018 at 06:49:41AM -0800, Andrey Smirnov wrote:
>> With MFD and watchdog drivers for RAVE SP device support added by
>> 538ee27290fa ("mfd: Add driver for RAVE Supervisory Processor") and
>> c3bb33345721 ("watchdog: Add RAVE SP watchdog driver") add
>> corresponding DT node for RDU2.
>>
>> Cc: Rob Herring <robh+dt@kernel.org>
>> Cc: Mark Rutland <mark.rutland@arm.com>
>> Cc: Shawn Guo <shawnguo@kernel.org>
>> Cc: Fabio Estevam <fabio.estevam@nxp.com>
>> Cc: Guenter Roeck <linux@roeck-us.net>
>> Cc: Chris Healy <cphealy@gmail.com>
>> Cc: Lucas Stach <l.stach@pengutronix.de>
>> Cc: devicetree@vger.kernel.org
>> Cc: linux-arm-kernel@lists.infradead.org
>> Cc: linux-kernel@vger.kernel.org
>> Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
>> ---
>> arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi | 11 +++++++++++
>> 1 file changed, 11 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi b/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi
>> index 72f52fcecee1..460931089509 100644
>> --- a/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi
>> +++ b/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi
>> @@ -305,6 +305,17 @@
>> pinctrl-names = "default";
>> pinctrl-0 = <&pinctrl_uart4>;
>> status = "okay";
>> +
>> + rave-sp {
>> + compatible = "zii,rave-sp-rdu2";
>> + current-speed = <1000000>;
>> + status = "okay";
>
> The okay status is to flip the state of devices that are initially
> disabled. I think it's unnecessary for the case here.

Good point, will respin v2 without that bit shortly.

Thanks,
Andrey Smirnov

\
 
 \ /
  Last update: 2018-03-01 17:20    [W:0.056 / U:0.584 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site