Messages in this thread | | | Date | Thu, 1 Mar 2018 17:37:21 +1100 | From | "Tobin C. Harding" <> | Subject | Re: [PATCH 3/5] staging: ks7010: Factor out repeated code into function 'ks_wlan_cap()'. |
| |
On Wed, Feb 28, 2018 at 09:19:09PM -0800, Quytelda Kahja wrote: > The code that generates a WLAN capability mask is repeated in five > functions. This change refactors that code into a new function, which is > called now in each of those functions.
Perhaps in future something like:
Code to generate the WLAN capability mask is duplicated five times
Add helper function to generate WLAN capability mask, refactor code to use newly defined function.
See Documentation/process/submitting-patches.rst section 2 for more info.
2) Describe your changes
Hope this helps, Tobin.
| |