lkml.org 
[lkml]   [2018]   [Mar]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] scsi: sd: Keep disk read-only when re-reading partition
On Thu, Mar 1, 2018 at 4:08 PM, Jeremy Cline <jeremy@jcline.org> wrote:
> If the read-only flag is true on a SCSI disk, re-reading the partition
> table sets the flag back to false.
>
> To observe this bug, you can run:
>
> 1. blockdev --setro /dev/sda
> 2. blockdev --rereadpt /dev/sda
> 3. blockdev --getro /dev/sda
>
> This commit reads the disk's old state and combines it with the device
> disk-reported state rather than unconditionally marking it as RW.

> - sdkp->write_prot = ((data.device_specific & 0x80) != 0);
> + sdkp->write_prot = ((data.device_specific & 0x80) != 0) ||
> + disk_ro;

Perhaps
sdkp->write_prot = (data.device_specific & 0x80) || disk_ro;

will save a line.

--
With Best Regards,
Andy Shevchenko

\
 
 \ /
  Last update: 2018-03-01 15:18    [W:0.080 / U:0.668 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site