lkml.org 
[lkml]   [2018]   [Mar]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/5] staging: ks7010: Factor out repeated code into function 'ks_wlan_cap()'.
On Thu, Mar 01, 2018 at 05:37:21PM +1100, Tobin C. Harding wrote:
> On Wed, Feb 28, 2018 at 09:19:09PM -0800, Quytelda Kahja wrote:
> > The code that generates a WLAN capability mask is repeated in five
> > functions. This change refactors that code into a new function, which is
> > called now in each of those functions.
>
> Perhaps in future something like:
>
> Code to generate the WLAN capability mask is duplicated five times
>
> Add helper function to generate WLAN capability mask, refactor code to
> use newly defined function.
>

I honestly don't see the difference between that and what Quytelda
wrote? I understood the original changelog just fine.

regards,
dan carpenter

\
 
 \ /
  Last update: 2018-03-01 12:20    [W:0.264 / U:0.104 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site